[CI] [doc] fix the dead link of resnet and mobilenet#17020
Closed
shaoyuyoung wants to merge 3 commits intoapache:mainfrom
Closed
[CI] [doc] fix the dead link of resnet and mobilenet#17020shaoyuyoung wants to merge 3 commits intoapache:mainfrom
shaoyuyoung wants to merge 3 commits intoapache:mainfrom
Conversation
shaoyuyoung
changed the title
Member
|
@tvm-bot rerun |
Author
|
Well, what went wrong? :( |
Member
|
@tvm-bot rerun |
yongwww
reviewed
May 24, 2024
| onnx = pytest.importorskip("onnx") | ||
|
|
||
| model_url = "https://github.com/onnx/models/raw/main/vision/classification/mobilenet/model/mobilenetv2-7.onnx" # pylint: disable=line-too-long | ||
| model_url = "https://github.com/onnx/models/raw/main/validated/vision/classification/mobilenet/model/mobilenetv2-7.onnx" # pylint: disable=line-too-long |
Member
There was a problem hiding this comment.
seems the https://github.com/apache/tvm/blob/main/tests/scripts/request_hook/request_hook.py should be updated.
Author
There was a problem hiding this comment.
I think (maybe) it can work now
shaoyuyoung
changed the title
Author
|
@leandron sry to bother you :( Can you take a look at this? I'm not sure I did the right thing |
Contributor
|
Thanks for the patch @shaoyuyoung, I believe this has been superseded by #17015, so I'll close this patch. Please reopen if that's not the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some dead links of resnet in the TVM doc.
one of these dead links has been caught in #17017 and a PR is submitted #17015
This PR fixes other dead links of resnet in tvm.
CC @leandron. When you do something about cache file in S3, maybe you need to pay attention to this part :)